Hi Gary,
+LGTM
Thanks,
Serguei
On 11/15/18 08:01, Roger Riggs wrote:
Looks fine, Roger
On 11/15/2018 09:41 AM, JC Beyler wrote:
Hi Gary,
Looks good to me (not a reviewer though),
Jc
On Thu, Nov 15, 2018 at 5:45 AM Gary Adams <gary.ad...@oracle.com
<mailto:gary.ad...@oracle.com>> wrote:
Here's a quick fix to add a missing copyright to signature.html.
diff --git
a/src/jdk.jdi/share/classes/com/sun/jdi/doc-files/signature.html
b/src/jdk.jdi/share/classes/com/sun/jdi/doc-files/signature.html
--- a/src/jdk.jdi/share/classes/com/sun/jdi/doc-files/signature.html
+++ b/src/jdk.jdi/share/classes/com/sun/jdi/doc-files/signature.html
@@ -1,4 +1,29 @@
<!DOCTYPE HTML>
+<!--
+ Copyright (c) 2018, Oracle and/or its affiliates. All rights
reserved.
+ DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+
+ This code is free software; you can redistribute it and/or
modify it
+ under the terms of the GNU General Public License version 2
only, as
+ published by the Free Software Foundation. Oracle designates this
+ particular file as subject to the "Classpath" exception as
provided
+ by Oracle in the LICENSE file that accompanied this code.
+
+ This code is distributed in the hope that it will be useful, but
WITHOUT
+ ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or
+ FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public
License
+ version 2 for more details (a copy is included in the LICENSE
file that
+ accompanied this code).
+
+ You should have received a copy of the GNU General Public
License version
+ 2 along with this work; if not, write to the Free Software
Foundation,
+ Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
+
+ Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA
94065 USA
+ or visit www.oracle.com <http://www.oracle.com> if you need
additional information or have any
+ questions.
+-->
+
<HTML lang="EN">
<HEAD>
<TITLE>
--
Thanks,
Jc