Hi Martin, That sounds good!
I've counted all the sh-shebangs and it appears that there are at least 66 of them inside the test/ directory, where only 12 bashes. I've also ran the search in order to identify all the occurrences that use either [[ or == and found only three of them that use "==". That one for example: http://hg.openjdk.java.net/jdk/sandbox/file/f94276ccc9fc/test/hotspot/jtreg/vmTestbase/jit/tiered/tieredTest.sh#l63 of course `dash` reports failure in that case. So I'm quite hesitant in that case and not really sure what to do. I haven't also found any existent JBS ticket for such /bin/sh => /bin/bash a replacement. So any advise in this case would be appreciated! Regards, Sergei On Mon, 10 Dec 2018 at 18:32, Martin Buchholz <marti...@google.com> wrote: > I would not try to remove all bash-isms from openjdk. Instead I would > find instances of /bin/sh that need to be changed to /bin/bash. > > (Ubuntu's use of /bin/sh -> /bin/dash is technically correct, but caused > much suffering > https://bugs.launchpad.net/ubuntu/+source/dash/+bug/61463 > ) >
