Re: RFR: JDK-8051349: nsk/jvmti/scenarios/sampling/SP06/sp06t003 fails in nightly

[Chris Plummer]

Agreed. We don't usually do a NSK_COMPLAIN without also failing the test. Among other things, it results in an error message and the fake exception in the log, which become a red herring if there is a real failure later on in the test. Otherwise changes look good to me too. Chris On 12/12/18 9:25 AM, JC Beyler wrote: Hi Gary, Looks good to me, especially since the SP02t003 does the same thing. Anyway we could do the same code as that test so that one day when we want to merge them with a common method, it will be easier to see that that specific code is identical (or really close from what I can tell):             if ((suspended == NSK_TRUE) && (frameStack[j].location != qLocation)) { Anyhow, it looks good to me. Thanks, Jc On Wed, Dec 12, 2018 at 8:55 AM Gary Adams <gary.ad...@oracle.com> wrote: After some testing with nsk verbose messages enabled, it is clear that this test is failing in checkThreads when the location did not match between the call to GetStackTrace and GetFrameLocation. For the tests that are run when the threads have not been suspended, there is no guarantee the locations will match.    Issue: https://bugs.openjdk.java.net/browse/JDK-8051349    Webrev: http://cr.openjdk.java.net/~gadams/8051349/webrev.00/ -- Thanks, Jc