On Thu, 13 Dec 2018 at 17:19, Severin Gehwolf <sgehw...@redhat.com> wrote:
>
> On Thu, 2018-12-13 at 15:49 +0000, Andrew Hughes wrote:
> > Ok, I presume that's not a change you're also going to make in
> > OpenJDK 12?
>
> Yes. I don't intend to change this in JDK 12. JDK 8 and JDK 9+ are not
> compatible in this regard. That's the case before and after this patch.
>
> > I'm fine with them being linked by the same bug ID, as they resolve the same
> > underlying issue, but this really needs to be clear in the summary
> > text, as, to the
> > uninformed, they look like completely different patches.
>
> OK will do. Can I consider this reviewed?
>
> Thanks,
> Severin
>

I'd like to see an updated webrev with a more detailed commit message first.

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Web Site: http://fuseyism.com
Twitter: https://twitter.com/gnu_andrew_java
PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222

Reply via email to