Hi Jini, I removed ps_get_thread_area() in new webrev:
http://cr.openjdk.java.net/~ysuenaga/JDK-8181313/webrev.02/ Diff from webrev.01 is here: http://hg.openjdk.java.net/jdk/submit/rev/691a931ae2ba Thanks, Yasumasa 2019年1月11日(金) 1:05 Jini George <jini.geo...@oracle.com>: > > Thanks, Yasumasa, but I meant removing the declaration and definition of > ps_get_thread_area() also. I don't think it is needed anymore. > > Thanks, > Jini. > > On 1/10/2019 6:50 PM, Yasumasa Suenaga wrote: > > Hi Jini, > > > > Thank you for your comment. > > I uploaded a new webrev: > > > > http://cr.openjdk.java.net/~ysuenaga/JDK-8181313/webrev.01/ > > > > It passed tests on submit repo. > > Could you review again? > > > > > > Yasumasa > > > > > > On 2019/01/10 15:10, Jini George wrote: > >> Thank you for implementing this change, Yasumasa. It looks good to me. > >> Just a nit. > >> > >> ==> linux/native/libsaproc/libproc_impl.c > >> Could you please remove these lines ? I don't think these are needed > >> anymore. > >> > >> 421 > >> 422 // new libthread_db of NPTL seem to require this symbol > >> 423 JNIEXPORT ps_err_e JNICALL > >> 424 ps_get_thread_area() { > >> 425 print_debug("ps_get_thread_area not implemented\n"); > >> 426 return PS_OK; > >> 427 } > >> > >> ==> linux/native/libsaproc/proc_service.h > >> Could you please remove these lines too ? > >> 79 > >> 80 // new libthread_db of NPTL seem to require this symbol > >> 81 JNIEXPORT ps_err_e JNICALL > >> 82 ps_get_thread_area(); > >> > >> Thanks, > >> Jini. > >> > >> > >> > >> On 1/9/2019 6:53 AM, Yasumasa Suenaga wrote: > >>> Hi all, > >>> > >>> Please review this change: > >>> > >>> JBS: https://bugs.openjdk.java.net/browse/JDK-8181313 > >>> webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8181313/webrev.00/ > >>> > >>> It has passed all tests on submit repo, and serviceability/sa tests on > >>> Linux x64. > >>> > >>> > >>> Thanks, > >>> > >>> Yasumas > >>>
