Hi Paul, Thanks, fixed all of the above in my local branch :-), Jc
On Fri, Jan 11, 2019 at 5:07 PM Hohensee, Paul <hohen...@amazon.com> wrote: > Nits: > > > > memAllocator.cpp: > > > > Copyright line should read > > > > * Copyright (c) 2018, 2019, Oracle and/or its affiliates. All rights > reserved. > > > > The comment > > > > // Tell tlab to forget the bytes_since if we passed it to the heap sampler. > > > > would be clearer if it read > > > > // Tell tlab to forget bytes_since_last if we passed it to the heap sampler. > > Same copyright line comment for HeapMonitor.java, > HeapMonitorArrayAllSampledTest.java and > HeapMonitorStatArrayCorrectnessTest.java > as for memAllocator.cpp. > > Otherwise lgtm, no need for another webrev on my account. > > > Thanks, > > > > Paul > > > > *From: *serviceability-dev <serviceability-dev-boun...@openjdk.java.net> > on behalf of JC Beyler <jcbey...@google.com> > *Date: *Thursday, January 10, 2019 at 11:28 AM > *To: *OpenJDK Serviceability <serviceability-dev@openjdk.java.net> > *Subject: *RFR(S) 8215113: Sampling interval not always correct > > > > Hi all, > > > > Could I get a review for this: > > Webrev: http://cr.openjdk.java.net/~jcbeyler/8215113/webrev.00/ > > Bug: https://bugs.openjdk.java.net/browse/JDK-8215113 > > > > This fixes the code to do the right accounting in sampling and get the > right sample counts and sampled objects. My error percentage calculation > was wrong so the two tests I had added were false positives (my apologies). > > > > Thanks, > > Jc > -- Thanks, Jc
