Hi Alex, Looks good to me.
Thanks! Best regards, Daniil On 1/17/19, 9:47 AM, "Alex Menkov" <alexey.men...@oracle.com> wrote: Hi Daniil, On 01/16/2019 22:27, Daniil Titov wrote: > Hi Alex, > > The change looks good to me but I think the copyright comment needs to be updated for year 2019. Updated the webrev in-place. --alex > > Thanks. > > Best regards, > Daniil > > On 1/16/19, 3:29 PM, "serviceability-dev on behalf of Alex Menkov" <serviceability-dev-boun...@openjdk.java.net on behalf of alexey.men...@oracle.com> wrote: > > Hi all, > > please review a fix for > https://bugs.openjdk.java.net/browse/JDK-8216386 > webrev: > http://cr.openjdk.java.net/~amenkov/popframe005_wait_time/webrev/ > > The fix updates WAIT_TIME to depend on test.timeout.factor system property. > WAIT_TIME value is used as argument of Thread.join(). > For the case when the thread is expected to be alive (i.e. Thread.join() > exits by timeout) the timeout value is restricted by 5 seconds to avoid > long run time with big timeout.factor values. > > --alex > > > >