+1
Thanks, Sharath -----Original Message----- From: Jini George Sent: Friday, February 01, 2019 9:46 AM To: Lindenmaier, Goetz; serviceability-dev@openjdk.java.net Subject: Re: JDK-8217473: SA: Tests using ClhsdbLauncher fail on SAP docker containers Thank you very much, Goetz, for running the tests and for taking a look at the changes. The only reason jstackOutput used to be null was due to the attach permission issues -- but now with the current change, test.run would throw the SkippedException for such cases, and would not reach the code parsing the jstackOutput. And in case jstackOutput is null without an exception from test.run, then that means the test has to fail. This applies to all the tests you have pointed out. Thank you, Jini. On 1/31/2019 8:41 PM, Lindenmaier, Goetz wrote: > ... and the tests passed. > https://ci.sapmachine.io/job/branch-build-linux_x86_64/12/JT_20Report_ > 20hotspot/ > > Unfortunately one can not see the jtr file to verify the right > exception was thrown. But they passed, so it's good. > > Why do you remove some checks for test failures from some tests? > Like > serviceability/sa/ClhsdbInspect.java > Why won't jstackOutput be null any more after your change? > > Others are: > serviceability/sa/ClhsdbJdis.java > serviceability/sa/ClhsdbLongConstant.java > serviceability/sa/ClhsdbPrintAs.java > serviceability/sa/ClhsdbRegionDetailsScanOopsForG1.java > serviceability/sa/ClhsdbScanOops.java > serviceability/sa/ClhsdbThread.java > > Are these all failures that go back to the attach issue? > > Best regards, > Goetz. > > >> -----Original Message----- >> From: Lindenmaier, Goetz >> Sent: Donnerstag, 31. Januar 2019 12:54 >> To: 'Jini George' <jini.geo...@oracle.com>; serviceability- >> d...@openjdk.java.net >> Subject: RE: JDK-8217473: SA: Tests using ClhsdbLauncher fail on SAP >> docker containers >> >> Hi Jini, >> >> I pushed it into our testing: >> https://ci.sapmachine.io/view/Build%20My%20Branch/job/branch-build- >> service/43/ >> >> the build is running ... >> >> Best regards, >> Goetz. >> >>> -----Original Message----- >>> From: serviceability-dev >>> <serviceability-dev-boun...@openjdk.java.net> On Behalf Of Jini >>> George >>> Sent: Mittwoch, 30. Januar 2019 12:59 >>> To: serviceability-dev@openjdk.java.net >>> Subject: RFR: JDK-8217473: SA: Tests using ClhsdbLauncher fail on >>> SAP >> docker >>> containers >>> >>> Requesting reviews for: >>> >>> BugID: https://bugs.openjdk.java.net/browse/JDK-8217473 >>> Webrev:http://cr.openjdk.java.net/~jgeorge/8217473/webrev.01/index.h >>> tml >>> >>> The patch includes changes to use SkippedException to skip the tests >>> when canPtraceAttachLinux() in Platform.java returns false. >>> >>> Thanks, >>> Jini. >
