Re: JDK-8214582: BasicJDWPConnectionTest.java: RuntimeException: Could not detect port from ''

[Daniil Titov]

Hi Alex,

+1

Thanks,
Daniil

On 2/11/19, 4:17 PM, "serviceability-dev on behalf of 
serguei.spit...@oracle.com" <serviceability-dev-boun...@openjdk.java.net on 
behalf of serguei.spit...@oracle.com> wrote:

    Hi Alex,
    
    It looks Okay to me.
    
    Thanks,
    Serguei
    
    
    On 2/11/19 15:20, Alex Menkov wrote:
    > Hi all,
    >
    > Please review the fix for
    > https://bugs.openjdk.java.net/browse/JDK-8214582
    > webrev:
    > http://cr.openjdk.java.net/~amenkov/BasicJDWPConnEmptyPort/webrev/
    >
    > The change fixes race condition when debuggee (LingeredApp) touches 
    > lock file, but the test haven't handled "Listening for transport ... 
    > at address ..." output.
    > Now the test waits up to 10 seconds (adjusted to TIMEOUT_FACTOR) for 
    > the required output.
    >
    > --alex