Re: RFR (S) 8220512: Deoptimize redefinition functions that have dirty ICs

[serguei.spit...@oracle.com]

Hi Coleen, It looks good to me. Just one minor suggestion: http://cr.openjdk.java.net/~coleenp/2019/8220512.01/webrev/src/hotspot/share/classfile/metadataOnStackMark.cpp.udiff.html - Threads::metadata_do(Metadata::mark_on_stack); - CodeCache::metadata_do(Metadata::mark_on_stack); + MetadataOnStackClosure mon_stack; + Threads::metadata_do(&mon_stack); + CodeCache::metadata_do(&mon_stack);  The 'mon_stack' can be associated with monitors.  How about to rename it to something like 'md_on_stack'? Thanks, Serguei On 3/14/19 10:40, coleen.phillim...@oracle.com wrote: Summary: Walk ICs to determine whether nmethods are dependent on redefined classes. See bug for more details.  Tested with redefinition tests: #redefinition tests. make test TEST=open/test/hotspot/jtreg/vmTestbase/nsk/jvmti >&jvmti.out make test TEST=open/test/hotspot/jtreg/vmTestbase/nsk/jdi >&jdi.out make test TEST=open/test/hotspot/jtreg/runtime/RedefineTests >&redefine.out make test TEST=open/test/jdk/java/lang/instrument >&instrument.out make test TEST=open/test/jdk/com/sun/jdi >&jtreg.jdi.out hs-tier1-6 as well as java/lang/instrument tests with -Xcomp. open webrev at http://cr.openjdk.java.net/~coleenp/2019/8220512.01/webrev bug link https://bugs.openjdk.java.net/browse/JDK-8220512 Thanks, Coleen