Updated webrev : http://cr.openjdk.java.net/~mbaesken/webrevs/8220355.2/
Alan + JC , may I add you as reviewers ? Thanks, Matthias From: Baesken, Matthias Sent: Montag, 18. März 2019 11:01 To: 'Alan Bateman' <[email protected]>; Jean Christophe Beyler <[email protected]> Cc: [email protected] Subject: RE: RFR: 8220355: Improve assertion texts and exception messages in eventHandlerVMInit Hi Alan, thanks for the review . > I think this looks okay except I think "emergency" should be dropped from the > message (and the existing comment). Are you referring to this “emergency” : * First make our emergency fallback InternalError throwable. */ result = initializeFallbackError(jnienv); - jplis_assert(result); + jplis_assert_msg(result, "emergency fallback init failed"); If you prefer I could output just “fallback init failed" - is this fine with you? Best regards, Matthias From: Alan Bateman <[email protected]<mailto:[email protected]>> Sent: Montag, 18. März 2019 10:09 To: Baesken, Matthias <[email protected]<mailto:[email protected]>>; Jean Christophe Beyler <[email protected]<mailto:[email protected]>> Cc: [email protected]<mailto:[email protected]> Subject: Re: RFR: 8220355: Improve assertion texts and exception messages in eventHandlerVMInit On 18/03/2019 08:54, Baesken, Matthias wrote: Hi JC, thanks for your comments . Second webrev , may I have a second review please ? http://cr.openjdk.java.net/~mbaesken/webrevs/8220355.1/ I think this looks okay except I think "emergency" should be dropped from the message (and the existing comment). -Alan
