Re: RFR(S) 8222935: Add forgotten files for ExceptionCheckingJniEnv

Wed, 24 Apr 2019 17:56:56 -0700

Hi Jc,

It looks good to me.

A couple of indent issues:

http://cr.openjdk.java.net/~jcbeyler/8222935/webrev.01/test/hotspot/jtreg/vmTestbase/nsk/share/ExceptionCheckingJniEnv/exceptionjni001.java.html

  Wrong indents at lines 48-50


http://cr.openjdk.java.net/~jcbeyler/8222935/webrev.01/test/hotspot/jtreg/vmTestbase/nsk/share/ExceptionCheckingJniEnv/exceptionjni001/exceptionjni001.cpp.html

  Wrong indent at 176 below:
 175 jint Agent_Initialize(JavaVM *jvm, char *options, void *reserved) {
 176     return JNI_OK;
 177 }

Thanks,
Serguei



On 4/24/19 16:42, Jean Christophe Beyler wrote:
Hi all,

Submit repo actually failed on the first version due to some loss of precision assignments. And also there was a slight bug in the exception messaging handling, so this is now fixed in the webrev:

This version passes the test and the submit repo:

Thanks for your help,
Jc


On Wed, Apr 24, 2019 at 11:10 AM Alex Menkov <[email protected]> wrote:
LGTM

--alex

On 04/24/2019 11:07, Jean Christophe Beyler wrote:
> Hi all,
>
> When pushing my fix for JDK-8213501, I did not push the added files
> which were the new test for the whole system.
>
> These were reviewed via the JDK-8213501
> (http://cr.openjdk.java.net/~jcbeyler/8213501/webrev.08/) fix but I'm
> just asking for a review again to add this webrev:
>
> Webrev: http://cr.openjdk.java.net/~jcbeyler/8222935/webrev.00/
> Bug: https://bugs.openjdk.java.net/browse/JDK-8222935
>
> My apologies for this... This has been sent to the submit repo in parallel.
>
> Thanks,
> Jc


--

Thanks,
Jc

Reply via email to