Hi Martin, 

the changes look good. 

Please fix this comment:
 // Forte Analyzer AsyncGetCallTrace profiling support is not implemented on 
Linux/S390x.
I guess it's no more true.  No new webrev needed.

Did you verify that the test works, or did you also try 
async with the VM on ppc?

Best regards,
  Goetz.

> -----Original Message-----
> From: Doerr, Martin
> Sent: Montag, 20. Mai 2019 17:32
> To: serviceability-dev@openjdk.java.net; JC Beyler <jcbey...@google.com>;
> Volker Simonis (volker.simo...@gmail.com) <volker.simo...@gmail.com>;
> Lindenmaier, Goetz <goetz.lindenma...@sap.com>
> Subject: RFR(S): 8224230: [PPC64, s390] Support AsyncGetCallTrace
> 
> Hi,
> 
> 
> 
> please review my change which allows usage of AsyncGetCallTrace on PPC64
> and s390.
> 
> 
> 
> Webrev:
> 
> http://cr.openjdk.java.net/~mdoerr/8224230_ppc_s390_AsyncCallTrace/webr
> ev.00/
> 
> 
> 
> Bug with more background information:
> 
> https://bugs.openjdk.java.net/browse/JDK-8224230
> 
> 
> 
> Best regards,
> 
> Martin
> 
> 

Reply via email to