Hi Alan, I think it makes sense to put the work for replacing revokeall.exe utility with a Java code in a separate issue since the current issue is a quite urgent.
I created a new issue for that https://bugs.openjdk.java.net/browse/JDK-8224255 Thanks! --Daniil On 5/19/19, 11:04 PM, "Alan Bateman" <alan.bate...@oracle.com> wrote: On 19/05/2019 22:12, Daniil Titov wrote: > Please review the change that fixes the failure of sun/management/jmxremote/bootstrap JMX tests on Windows platform. While running, these tests invoke revokeall.exe utility and this utility hangs. > > The problem here is that invokeall.exe goes into an endless loop while iterating over Access Control Entries (ACE) for a given file if it encounters at least one ACE with the type different from ACCESS_ALLOWED_ACE_TYPE. > > The change fixes this problem. It also removes revokeall.exe binary from the repository and changes the makefile to get it built instead. > > Tier1, tier2, tier3, jdk_svc, and sun/management/jmxremote/bootstrap tests succeeded in Mach5. > > Webrev: http://cr.openjdk.java.net/~dtitov/8214545 > Bug: https://bugs.openjdk.java.net/browse/JDK-8214545 Have you looked at replacing the tool with code that uses the java.nio.file API? You can edit ACLs with that API. -Alan
