Hi Jon, It looks good to me as well (not an official reviewer though :-)), Jc
On Tue, Jun 4, 2019 at 5:09 PM <serguei.spit...@oracle.com> wrote: > Hi Jon, > > Looks good to me. > > Thanks, > Serguei > > > On 6/4/19 2:42 PM, Jonathan Gibbons wrote: > > Please review another small patch for the jdk.jdi module, to fix a > > missing heading in one file and to adjust a heading in another. > > > > No webrev; patch below. > > > > That being said, the file > > src/jdk.jdi/share/classes/com/sun/jdi/doc-files/signature.html barely > > warrants being its own file, but even what content there is deserves > > to be fixed. The table caption is oversized, the table has no borders > > and not not use any CSS to "stripe" the rows. However, that cleanup is > > out of scope for this accessibility fix for the headings. > > > > -- Jon > > > > JBS: https://bugs.openjdk.java.net/browse/JDK-8225309 > > > > > > $ hg diff -R open > > diff -r 4158e6a864d4 > > src/jdk.jdi/share/classes/com/sun/jdi/doc-files/signature.html > > --- a/src/jdk.jdi/share/classes/com/sun/jdi/doc-files/signature.html > > Tue Jun 04 13:47:59 2019 -0700 > > +++ b/src/jdk.jdi/share/classes/com/sun/jdi/doc-files/signature.html > > Tue Jun 04 14:35:34 2019 -0700 > > @@ -41,6 +41,7 @@ > > </HEAD> > > <BODY style="background-color:white"> > > <div role="main"> > > +<h1>JDI Type Signatures</h1> > > <Table Border="0"> > > <caption style="font-size:x-large"><b>JDI Type Signatures</b></caption> > > <thead> > > diff -r 4158e6a864d4 src/jdk.jdi/share/classes/module-info.java > > --- a/src/jdk.jdi/share/classes/module-info.java Tue Jun 04 13:47:59 > > 2019 -0700 > > +++ b/src/jdk.jdi/share/classes/module-info.java Tue Jun 04 14:35:34 > > 2019 -0700 > > @@ -46,7 +46,7 @@ > > * This module includes a simple command-line debugger, > > * <em>{@index jdb jdb tool}</em>. > > * > > - * <h3>Global Exceptions</h3> > > + * <h2>Global Exceptions</h2> > > * <p> > > * This section documents exceptions which apply to the entire API > > and are thus > > * not documented on individual methods. > > > > -- Thanks, Jc
