Hi Daniil, Looks good to me :)
Thanks, Jc On Fri, Jun 7, 2019 at 11:47 AM Daniil Titov <daniil.x.ti...@oracle.com> wrote: > Please review the change that fixes an intermittent failure of the test > when it is run with Graal on. > > The test starts a debuggee and sets the method entry breakpoint for > tc02x004aClass1 class that has only constructor defined. > The debuggee starts 3 threads and each of them creates a new instance of > tc02x004aClass1 class. The test waits for receiving > 3 method entry events (posted when the constructor of tc02x004aClass1 is > invoked) during a specific amount of time. > > The problem here is that with Graal on it takes more time for the test to > run and occasionally the test stops listening for events > before all method entry events are delivered. > > The fix ensures that the time the test waits for receiving method entry > events is adjusted for test.timeout.factor factor. > > The fix also makes the test waiting till the debuggee terminates before > exiting. > > Webrev: http://cr.openjdk.java.net/~dtitov/8222828/webrev.01 > Bug: https://bugs.openjdk.java.net/browse/JDK-8222828 > > Thanks! > -Daniil > > > -- Thanks, Jc
