v2 looks good as well
--alex
On 07/01/2019 18:12, serguei.spit...@oracle.com wrote:
Hi Alex,
Thank you for the review!
Could also look at the webrev v2? :
http://cr.openjdk.java.net/~sspitsyn/webrevs/2019/8226596-jdwp-a11y.2/
This change also updates page headings (result of our discussion with
David H.).
Thanks,
Serguei
On 7/1/19 18:02, Alex Menkov wrote:
LGTM
--alex
On 07/01/2019 14:15, David Holmes wrote:
Hi Serguei,
On 2/07/2019 4:57 am, serguei.spit...@oracle.com wrote:
Please, review a doc issue fix for:
https://bugs.openjdk.java.net/browse/JDK-8226596
Webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2019/8226596-jdwp-a11y.1/
The updated JDWP protocol page:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2019/jdwp-protocol.html
Summary:
The change is to replace the 'navigation' attribute with the
<nav> element.
That looks fine.
With this fix, the Axe reports one issue only:
"Page must contain a level one heading".
I'm not sure what to do to workaround this.
The page was not initially designed to have a level one heading.
It has to be normally used in the context of enclosed page which
haswith a level one heading.
Not sure what you mean by an "enclosed page". Where can I see this in
context?
Thanks,
David
-----
Testing:
Verified with the Axe plugin (add-on) for Mozilla Firefox browser.
Asked Alex M. to double-check this, and his Axe reported no errors.
Thanks,
Serguei
