Hi Serguei,
Overall looks good. A few questions:
I don't understand the need for all the 'i' and 'n' theatrics in the
shouldFinish loop. Can you explain and also add a comment?
Is this comment right?
193 // set thread is not ready again
194 public void setAllThreadsReady() {
195 allThreadsReady = true;
196 }
Also, shouldn't "setAllThreadsReady()" be static?
Do you think it would be useful to also run the test with the last
thread in the list being the suspender thread?
thanks,
Chris
On 9/27/19 6:25 PM, serguei.spit...@oracle.com wrote:
Please, review fix for test enhancement:
https://bugs.openjdk.java.net/browse/JDK-8231595
Webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2019/8231595-jvmti-susp-tlist.1/
Summary:
New test is a coverage for the JVMTI bug:
https://bugs.openjdk.java.net/browse/JDK-8217762
SuspendThreadList won't work correctly if the current thread is
not last in the list
It provides a prove the bug JDK-8217762 does not exist
as the test is passed with the current implementation.
Thanks,
Serguei
