Re: RFR: JEP 359-Records: hotspot runtime and serviceability code

Wed, 23 Oct 2019 00:49:00 -0700

Hi Vicente and Harold,

I'm still reviewing this, it looks pretty good so far.

One quick comment about a pre-existed issue (not your fault).
The jvmti.xml has an update to add the Record attribute into the list of attributes that must not be changed:
7789         The retransformation must not change the <code>NestHost</code>,
7790         <code>NestMembers</code>, or <code>Record</code> attributes.
The line 7789 has to say:
7789         The redefinition must not change the <code>NestHost</code>,
Could you, please, fix this?

Thanks,
Serguei


On 10/18/19 11:44, Vicente Romero wrote:
Hi,

Please review the hotspot runtime and serviceability code for JEP 359 (Records).

Thanks in advance for the feedback,
Vicente

PS, Thanks to Harold for the development


[1] http://cr.openjdk.java.net/~vromero/records.review/hotspot_runtime/webrev.00/

Reply via email to