Hi Simon,
+1
Thanks,
Serguei
On 10/24/19 08:55, Chris Plummer wrote:
Hi Simon,
The changes look good.
thanks,
Chris
On 10/24/19 7:16 AM, Simon Tooke wrote:
Hello,
While reviewing uses of strtok() with an eye to moving to strtok_r(),
I came accross an inifinite loop in the macOS agent code, but one
that has probably never been executed. In the interests of not
having even potential loops, I've file a bug and have a PR to
submit. My patch removes the inifinite loop and switches to
strtok_r(). The switch to the reentrant version is not required in
this use case but I include it so that this code doesn't show up on
future scans for strtok() usage.
Bug: https://bugs.openjdk.java.net/browse/JDK-8232973
Webrev: http://cr.openjdk.java.net/~stooke/webrevs/jdk-8232973-jdk/00/
Are there any concerns?
Thanks,
-Simon
