Hi Ralf, Okay, thanks! Serguei
On 11/11/19 00:48, Schmelter, Ralf wrote:
Hi Serguei, Thanks for the review. The only open question seems to be:The dumper.dump() returns int value. Returned value is not used anymore in the attachListener.cpp and diagnisticCommand.cpp. Is it still used somewhere else or we can replace it with void?The jmm_DumpHeap0 method still uses the return code (and the error string) to throw an exception in case of an error. Best regards, Ralf
