Looks good.

Chris

On 11/18/19 11:30 AM, Alex Menkov wrote:
Hi Chris,

It makes sense.
I created new issue and closed JDK-8187143 as a dup of JDK-8225620

So changing this RFR to be RFR for the new issue:
https://bugs.openjdk.java.net/browse/JDK-8234358

The changes is the same:

--- a/test/jdk/ProblemList.txt  Fri Nov 15 14:22:24 2019 -0800
+++ b/test/jdk/ProblemList.txt  Fri Nov 15 15:20:28 2019 -0800
@@ -845,7 +845,7 @@

 com/sun/jdi/RepStep.java 8043571 generic-all

-com/sun/jdi/NashornPopFrameTest.java 8187143 generic-all
+com/sun/jdi/NashornPopFrameTest.java 8225620 generic-all


############################################################################


--alex

On 11/15/2019 17:31, Chris Plummer wrote:
Hi Alex,

Actually I take that back. Removing from the problem list should either be done as part of a bug fix, for which there is none here, or done for a bug specifically for removing from the problem list. Since you are not actually fixing JDK-8187143 (it seems to no longer be a bug), I suggest you close it as CNR and file a new bug for the problem list update.

thanks,

Chris

On 11/15/19 5:26 PM, Chris Plummer wrote:
Looks good.

Chris

On 11/15/19 3:58 PM, Alex Menkov wrote:
Hi all,

Please review small fix for
https://bugs.openjdk.java.net/browse/JDK-8187143

The issue is not reproducible from JDK10, but now test fails NashornPopFrameTest fails with "MemberName required for invokeVirtual etc" error, i.e. this is a dup of
https://bugs.openjdk.java.net/browse/JDK-8225620

The fix updates ProblemList.txt to point to 8225620

The diff:
--- a/test/jdk/ProblemList.txt    Fri Nov 15 14:22:24 2019 -0800
+++ b/test/jdk/ProblemList.txt    Fri Nov 15 15:21:53 2019 -0800
@@ -845,7 +845,7 @@

 com/sun/jdi/RepStep.java 8043571 generic-all

-com/sun/jdi/NashornPopFrameTest.java 8187143 generic-all
+com/sun/jdi/NashornPopFrameTest.java 8225620 generic-all


############################################################################


--alex






Reply via email to