On 11/22/19 6:45 PM, serguei.spit...@oracle.com wrote:
Hi Coleen,
It looks good in general.
Just one minor request:
http://cr.openjdk.java.net/~coleenp/2019/8173658.01/webrev/src/hotspot/share/prims/jvmtiImpl.hpp.frames.html
http://cr.openjdk.java.net/~coleenp/2019/8173658.01/webrev/src/hotspot/share/prims/jvmtiImpl.cpp.frames.html
Could you, please, rename:
TYPE_CLASS_UNLOADED => TYPE_CLASS_UNLOAD
and class_unloaded => class_unload
to keep it consistent with TYPE_COMPILED_METHOD_UNLOAD and
compiled_method_unload?
Thank you for taking care about this!
Thanks for reviewing this. I fixed them both.
Coleen
Thanks,
Serguei
On 11/22/19 11:42, coleen.phillim...@oracle.com wrote:
Summary: call extension ClassUnload event as a deferred event from
the ServiceThread and remove unsafe arguments
I'm still waiting for the CSR request to get approved but this change
fixes the broken class unload events. It's been tested with the
existing test case, and hs-tier1 for all platforms and tier2-6 on
linux-x64-debug.
open webrev at
http://cr.openjdk.java.net/~coleenp/2019/8173658.01/webrev
bug link https://bugs.openjdk.java.net/browse/JDK-8173658
Thanks,
Coleen
