Looks good.
thanks,
Chris
On 12/13/19 5:02 AM, Fairoz Matte wrote:
Hi Chris,
Thanks for the review,
Please find the webrev.01 with usage of INAVLID_LOAD_ADDRESS macro for -1L.
I have also added one more macro for ZERO_LOAD_ADDRESS for 0x0L.
http://cr.openjdk.java.net/~fmatte/8235637/webrev.01/
Thanks,
Fairoz
-----Original Message-----
From: Chris Plummer
Sent: Thursday, December 12, 2019 9:48 PM
To: Fairoz Matte <fairoz.ma...@oracle.com>; serviceability-dev@openjdk.java.net
Subject: Re: RFR: 8235637: jhsdb jmap from OpenJDK 11.0.5 doesn't work if
prelink is enabled
Can you use a macro for -1L? Maybe INAVLID_LOAD_ADDRESS or LOAD_ADDRESS_ERROR.
Chris
On 12/11/19 7:10 PM, Fairoz Matte wrote:
Hi,
Please review this small change,
Updating error handling, to make sure "lib_base_diff = 0" is still a valid
scenario even after calc_prelinked_load_address() call.
JBS - https://bugs.openjdk.java.net/browse/JDK-8235637
Webrev - http://cr.openjdk.java.net/~fmatte/8235637/webrev.00/
This patch is provided by Yasumasa Suenaga
Thanks,
Fairoz
