Hi Robbin,
The fix looks good to me.
At least, I do not see any issues with it.
Thank you for removing the unused code!
Could you be more precise about on what jvmti/jdi tests you run?
For good test coverage we need these test suites:
vmTestbase_nsk_jvmti, vmTestbase_nsk_jdi, vmTestbase_nsk_jdb, jdk_jdi
They have to be present in the t1-7.
I list them in a case if you want to run them with some specific options.
Thanks,
Serguei
On 12/16/19 01:47, Robbin Ehn wrote:
Hi all, please review.
From issue, https://bugs.openjdk.java.net/browse/JDK-8235912:
JvmtiBreakpoints are walked via VMThread oops_do (the breakpoint is in
a vm operation) before they are installed in the safeopint and after
they have been installed, walked with JvmtiCurrentBreakpoints::oops_do().
By putting the class holder inside oopStorage there is no need for this.
JvmtiCurrentBreakpoints::metadata_do is not needed because redefine
classes actually removes the breakpoints before updating them (so
there is no breakpoints to update).
We can just remove metadata_do.
I also removed some unused code.
Changeset:
http://cr.openjdk.java.net/~rehn/8235912/v1/webrev/
Passes several runs of nsk jvmti/jdi and t1-7.
Thanks, Robbin
