On 2020/01/04 15:48, Chris Plummer wrote:
Hi Yasumasa,
On 1/3/20 7:28 PM, Yasumasa Suenaga wrote:
Hi Chris,
Thanks for your review!
On 2020/01/04 5:12, Chris Plummer wrote:
Hi Yasumasa,
The change looks fine, but shouldn't there be a regression test for this
feature? It looks like JMXStartStopTest covers some of the options, but most
are not tested. Seems we should at least have a test to confirm that the
correct property is set.
I agree with you, but it should be handled as another issue IMHO.
All parameters in command line seem to be tested in
test/jdk/sun/management/jmxremote/bootstrap.
I don't see them all being tested. For example, I don't see any jdb related
properties being tested, and also noticed some jmxremote ones are missing.
I guess we can port them to jcmd tests, but it might be hard.
I think as long as the bootstrap tests provide the coverage, the only thing the
jcmd tests need to test for is that the property gets set.
I will file it to JBS and will push 8236552 if you are ok.
What do you think?
That sounds fine.
I file it to JBS: https://bugs.openjdk.java.net/browse/JDK-8236649
Thanks,
Yasumasa
thanks,
Chris
Thanks,
Yasumasa
thanks,
Chris
On 12/26/19 8:10 PM, Yasumasa Suenaga wrote:
Hi all,
Please review this trivial fix:
JBS: https://bugs.openjdk.java.net/browse/JDK-8236552
webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8236552/webrev.00/
ManagementAgent.start dcmd provides jmxremote.ssl.config.file for SSL
configuration. We can see description as below:
```
jmxremote.ssl.config.file : [optional] set
com.sun.management.jmxremote.ssl_config_file (STRING, no default value)
```
This option would set com.sun.management.jmxremote.ssl.config.file, not
ssl_config_file.
Thanks,
Yasumasa
