Hi Christoph, thanks for the review ! Will push it as XS in case no objections show up .
Best regards, Matthias From: Langer, Christoph <christoph.lan...@sap.com> Sent: Montag, 10. Februar 2020 10:01 To: Baesken, Matthias <matthias.baes...@sap.com>; serviceability-dev@openjdk.java.net Subject: RE: RFR [XS]: 8238602: remove obsolete functions from libinstrument/FileSystemSupport_md.c Hi Matthias, I think this removal is ok. I can see that you tested the patch in our CI without regressions. So +1 from my end. Cheers Christoph From: serviceability-dev <serviceability-dev-boun...@openjdk.java.net<mailto:serviceability-dev-boun...@openjdk.java.net>> On Behalf Of Baesken, Matthias Sent: Donnerstag, 6. Februar 2020 17:06 To: serviceability-dev@openjdk.java.net<mailto:serviceability-dev@openjdk.java.net> Subject: [CAUTION] RFR [XS]: 8238602: remove obsolete functions from libinstrument/FileSystemSupport_md.c Hello, the link time section gc (see https://bugs.openjdk.java.net/browse/JDK-8236714 , on linux s390x it prints the removed sections) showed some obsolete / unused functions in FileSystemSupport_md.c : ld: Removing unused section '.text.pathSeparator' in file '/nightly/output-jdk-dev/support/native/java.instrument/libinstrument/FileSystemSupport_md.o' ld: Removing unused section '.text.filenameStrcmp' in file '/nightly/output-jdk-dev/support/native/java.instrument/libinstrument/FileSystemSupport_md.o' They can be cleaned up. Bug/webrev : https://bugs.openjdk.java.net/browse/JDK-8238602 http://cr.openjdk.java.net/~mbaesken/webrevs/8238602.0/ Thanks, Matthias
