Hi Matthias, I think this is good. In line 1187 of src/jdk.hotspot.agent/solaris/native/libsaproc/saproc.cpp, there’s a space missing after the if. I guess you should insert it before pushing 😊
Cheers Christoph From: serviceability-dev <[email protected]> On Behalf Of Baesken, Matthias Sent: Mittwoch, 19. Februar 2020 15:22 To: '[email protected]' <[email protected]> Cc: [email protected] Subject: [CAUTION] RFR [XS]: 8239462: jdk.hotspot.agent misses some ReleaseStringUTFChars calls in case of early returns Hello, please review this small change . We miss at a few places ReleaseStringUTFChars calls in the native jdk.hotspot.agent coding. This happens in case of early returns . Bug/webrev : https://bugs.openjdk.java.net/browse/JDK-8239462 http://cr.openjdk.java.net/~mbaesken/webrevs/8239462.0/ Thanks, Matthias
