Yeah, I think given that it fixes a broken build it should be fine to
push right away.
Chris
On 3/27/20 10:10 AM, Aleksey Shipilev wrote:
Thanks! Trivial, right?
If so, I'll push as soon as jdk-submit clears.
-Aleksey
On 3/27/20 6:08 PM, Chris Plummer wrote:
+1
Chris
On 3/27/20 10:03 AM, Roman Kennke wrote:
Looks good to me, thanks!
Roman
Bug:
https://bugs.openjdk.java.net/browse/JDK-8241750
Fix:
diff -r fef47d126675 src/jdk.jdwp.agent/share/native/libjdwp/classTrack.c
--- a/src/jdk.jdwp.agent/share/native/libjdwp/classTrack.c Fri Mar 27
15:33:24 2020 +0100
+++ b/src/jdk.jdwp.agent/share/native/libjdwp/classTrack.c Fri Mar 27
17:47:31 2020 +0100
@@ -70,5 +70,5 @@
return;
}
- *(char**)bagAdd(deletedSignatures) = (char*)tag;
+ *(char**)bagAdd(deletedSignatures) = (char*)jlong_to_ptr(tag);
debugMonitorExit(classTrackLock);
@@ -118,5 +118,5 @@
EXIT_ERROR(error,"signature");
}
- error = JVMTI_FUNC_PTR(trackingEnv, SetTag)(env, klass, (jlong)signature);
+ error = JVMTI_FUNC_PTR(trackingEnv, SetTag)(env, klass,
ptr_to_jlong(signature));
if (error != JVMTI_ERROR_NONE) {
jvmtiDeallocate(signature);
Testing: Linux {x86_64, x86_32} x {builds, vmTestbase_nsk_jdwp}; jdk-submit
(running)
