Hi Daniil,
LGTM++
Thanks,
Serguei
On 3/30/20 13:06, Alex Menkov wrote:
Looks good.
--alex
On 03/30/2020 12:43, Daniil Titov wrote:
Please review the change [1] that fixes the failure of
com/sun/jdi/JdwpListenTest.java
and com/sun/jdi/JdwpAttachTest.java tests on OSX 10.15.
The problem here is the similar to the one solved in [4] by
additional filtering
of unusual network interfaces in the test library class
jdk.test.lib.NetworkConfiguration.
However, the failing com/sun/jdi tests do not use
jdk.test.lib.NetworkConfiguration and
Instead do repeat the same logic themselves.
The fix changes these tests to start using
jdk.test.lib.NetworkConfiguration to find all local addresses.
Initially the issue [2] also included 3 other failing tests from
sun/management/jdp package, but these tests fail
for a different reason so I moved them in the new issue [3] and
updated the ProblemList.txt for them.
[1] Webrev: http://cr.openjdk.java.net/~dtitov/8241530/webrev.01/
[2] Jira Issue: https://bugs.openjdk.java.net/browse/JDK-8241530
[3] https://bugs.openjdk.java.net/browse/JDK-8241865
[4] https://bugs.openjdk.java.net/browse/JDK-8241336
Thank you,
Daniil
