Thanks Igor and Leonid!
Chris
On 4/6/20 1:38 PM, Igor Ignatev wrote:
LGTM
— Igor
On Apr 5, 2020, at 11:49 PM, Chris Plummer <[email protected]> wrote:
[Sorry about the resend. Subject wasn't quite right the first time.]
Hello,
Please help review the following:
https://bugs.openjdk.java.net/browse/JDK-8242168
http://cr.openjdk.java.net/~cjplummer/8242168/webrev.00/
ClhsdbFindPC needs to be disabled when using -XX:+DeoptimizeALot because it
means the expected compiled frame may not be compiled. I also fixed
ClhsdbJstackXcompStress since it also relies on frames being compiled, although
I never got it to fail since it managed to always find at least one compiled
frame.
I confirmed that with this fix these two tests are not run when
-XX:+DeoptimizeALot is used. If not used, behavior is unchanged.
ClhsdbFindPC.java#id0 runs whether or not using -Xcomp and #id1 still only runs
when not using -Xcomp. ClhsdbJstackXcompStress gets run whether or not -Xcomp
is used.
thanks,
Chris
