Hi Chris,
This looks good.
Thanks,
Serguei
On 4/16/20 10:18, Chris Plummer wrote:
Hello,
Please review the following:
https://bugs.openjdk.java.net/browse/JDK-8242787
http://cr.openjdk.java.net/~cjplummer/8242787/webrev.00/index.html
After fixing JDK-8230731 [1], this test still failed, this time with a
WrongTypeException. The issue is basically the same one as was just
fixed in JDK-8235220 [2]. With CDS on you sometimes get a
WrongTypeException instead of an AddressException, so in some places
code that allows an AddressException needs to also allow a
WrongTypeException.
Note that fixing this issue then exposes JDK-8242789 [3], which I'll
be fixing next, so the problem list entry changed from JDK-8242787 to
JDK-8242789.
I also did a bit of cleaning up of some debugging code. During my
debugging session I set DEBUG = true to get some extra debugging
output, and suddenly a lot of tests were failing with a
RuntimeException. This is because of the debugging code I've now
stripped out. It decided to convert an acceptable failure type
(UnknownOopException) into one that the outer try/catch would not
catch (RuntimeException). UnknownOopException is not suppose to cause
iterateLiveRegions() to abort.
https://bugs.openjdk.java.net/browse/JDK-8230731
https://bugs.openjdk.java.net/browse/JDK-8235220
https://bugs.openjdk.java.net/browse/JDK-8242789
thanks,
Chris
