Hi Serguei, thanks for review, no I haven't yet as I found another problem w/ 8243928.
-- Igor > On Apr 27, 2020, at 10:14 PM, serguei.spit...@oracle.com wrote: > > Hi Igor, > > Looks good but you have already pushed. :) > > Thanks, > Serguei > > > On 4/27/20 22:10, Mikael Vidstedt wrote: >> Looks good, thanks for the quick turnaround! >> >> Cheers, >> Mikael >> >>> On Apr 27, 2020, at 10:02 PM, Igor Ignatyev <igor.ignat...@oracle.com> >>> wrote: >>> >>> http://cr.openjdk.java.net/~iignatyev//8243946/webrev.00 >>>> 2 lines changed: 0 ins; 0 del; 2 mod; >>> Hi all, >>> >>> (so now it's my time to apology for inconvenience) >>> >>> could you please review this small follow-up fix/partial revert of >>> 8243928[1]? serviceability/sa/TestCpoolForInvokeDynamic.java and >>> TestDefaultMethods.java test use non-exported API so they can't be run in >>> driver mode (b/c jtreg use vanilla JVM for driver code, meaning even >>> exports from @modules tags are ignored) >>> >>> JBS: https://bugs.openjdk.java.net/browse/JDK-8243946 >>> testing: test/hotspot/jtreg/serviceability (in progress) >>> webrev: http://cr.openjdk.java.net/~iignatyev//8243946/webrev.00 >>> >>> [1] https://bugs.openjdk.java.net/browse/JDK-8243928 >>> >>> Thanks, >>> -- Igor >
