Hi Daniil,
Overall looks good. Just one minor thing. In ClassTypeImpl.c and
ObjectReferenceImpl.c I think the following would be more readable with
an if/else:
79 return JNI_FUNC_PTR(env,ExceptionOccurred)(env) ?
AGENT_ERROR_JNI_EXCEPTION
80 : JVMTI_ERROR_NONE;
Also, have you filed a CR for the JDWP spec issues related to missing
type information in some of the protocol packet descriptions?
thanks,
Chris
On 5/9/20 9:29 AM, Daniil Titov wrote:
Please review a change[1] that centralizes the signature processing in
serviceability tools to make it capable of being easily extensible in the
future.
Testing: Mach5 tier1-tier3 tests successfully passed.
[1] http://cr.openjdk.java.net/~dtitov/8241080/webrev.01
[2] https://bugs.openjdk.java.net/browse/JDK-8241080
Thank you,
Daniil