Hi Alex,
LGTM
Thank you for the update!
Serguei
On 5/11/20 14:14, Alex Menkov wrote:
Hi Serguei, Alan,
Updated webrev:
http://cr.openjdk.java.net/~amenkov/jdk15/java_instrument_spec/webrev.2/
--alex
On 05/11/2020 11:52, Alan Bateman wrote:
On 11/05/2020 19:21, serguei.spit...@oracle.com wrote:
Hi Alex,
There is no need to repeat this:
"deploy applications thatpackage an agent with the application,
or use tools that load agents into a running application"
I'd suggest to rephrase it to something like:
"Agents can transform classes in arbitrary ways at load time,
transform
modules, or transform the bytecode of methods of already loaded
classes.
Developers or administrators that deploy agents are responsible
for their
trustworthiness and must therefore verify each agent including
the content
and structure of its JAR file."
Also, could you, please, replace:
* <p> The three ways to start an agent is described below.
with:
* <p> The three ways to start an agent are described below.
Serguei's suggestions look good.
-Alan