On 22/05/2020 18:50, Alex Menkov wrote:
Hi all,

please review the fix for
https://bugs.openjdk.java.net/browse/JDK-8244703
webrev:
http://cr.openjdk.java.net/~amenkov/jdk15/jdwp_javalib_dep/webrev/

The issue is a regression from JDK-8222529 which introduced dependency jdwp lib of java lib. The fix removes the dependency and implements platform to utf8 conversion using existing jdwp code.
This looks good to me. While we are in the area, can you look at printLastError in transport.c? I'm just wondering if parentheses could be added to "len+len/2+2" to make it clear how maxlen is set.

-Alan.


Reply via email to