Hi Chris,
LGTM++
Thanks,
Serguei
On 8/3/20 16:19, Alex Menkov wrote:
Hi Chris,
Looks good
--alex
On 08/03/2020 14:53, Chris Plummer wrote:
Ping! This is a fairly trivial testing fix to avoid timeouts when
using LingeredApp to generate a core dump. No knowledge of SA is needed.
thanks,
Chris
-------- Forwarded Message --------
Subject: RFR(XXS): 8249150: SA core file tests sometimes time out
on OSX with "java.io.IOException: App waiting timeout"
Date: Fri, 31 Jul 2020 11:07:01 -0700
From: Chris Plummer <chris.plum...@oracle.com>
To: serviceability-dev <serviceability-dev@openjdk.java.net>
Hello,
Please help review the following:
https://bugs.openjdk.java.net/browse/JDK-8249150
http://cr.openjdk.java.net/~cjplummer/8249150/webrev.00/index.html
The tests in question use recently added LingeredApp support for
dumping a core file. On OSX a core file dump sometimes takes a very
long time, exceeding the amount of time Lingeredapp.waitAppReady() is
willing to wait. This wait time needs to be increased to allow the
core file to finish dumping, and also a couple of the tests that use
the LingeredApp core file support need longer test timeouts. Note
ClhsdbFindPC already has a long timeout, so no timeout changes were
needed for it.
Tested by running all serviceability/sa tests once on all platforms,
and 400 times on OSX (200 regular runs and 100 -Xcomp runs).
thanks,
Chris
