Hi Paul and Serguei,
Thanks for your comments, here is the updated patch:
http://cr.openjdk.java.net/~lzang/8251374/webrev02/
BRs,
Lin
On 2020/8/13, 12:55 AM, "serguei.spit...@oracle.com"
<serguei.spit...@oracle.com> wrote:
Hi Lin,
It looks good.
Just one comment.
+ System.err.println("Fail: invalid option: '" + subopt
+"'");
+ System.exit(1);
Exit needs to be replaced wit usage for consistency.
Thanks,
Serguei
On 8/10/20 19:57, linzang(臧琳) wrote:
> Here is the webrev: http://cr.openjdk.java.net/~lzang/8251374/webrev01/
>
> BRs,
> Lin
>
> On 2020/8/11, 10:52 AM, "linzang(臧琳)" <linz...@tencent.com> wrote:
>
> Hi All,
> May I ask your help to review this tiny patch? It fix an issue
that jmap -dump could wrongly accept invalid optioins.
> Bugs: https://bugs.openjdk.java.net/browse/JDK-8251374
> Patch: (Can not connect to webrev ftp currently, will try it
later, following are all code changes)
>
> ################################
> --- old/src/jdk.jcmd/share/classes/sun/tools/jmap/JMap.java
2020-08-11 10:42:32.044567791 +0800
> +++ new/src/jdk.jcmd/share/classes/sun/tools/jmap/JMap.java
2020-08-11 10:42:31.876568681 +0800
> @@ -207,6 +207,11 @@
> liveopt = "-live";
> } else if (subopt.startsWith("file=")) {
> filename = parseFileName(subopt);
> + } else if (subopt.equals("format=b")) {
> + // ignore format (not needed at this time)
> + } else {
> + System.err.println("Fail: invalid option: '" +
subopt +"'");
> + System.exit(1);
> }
> }
> ################################
>
> Thanks,
> Lin
>
>
