That's something that's very hard to do. It would involve black listing
the existing changeset and repushing a new changeset. Black listing a
changeset is very, very rarely done and in the past Ops has declined to
do that for something like an authorship error.
Two options:
1) Manually remember that this changeset should be credited to Lin
as author.
2a) [BACKOUT] the changeset using a new bug ID.
2b) [REDO] the changeset with corrected author information with a new
bug ID.
Dan
On 8/13/20 2:36 PM, Hohensee, Paul wrote:
I mistakenly committed and pushed Lin's patch with myself as author. Would
someone with repo access please change the author to 'lzang'? Or tell me how to
do it myself?
https://hg.openjdk.java.net/jdk/jdk/rev/5036ca733469
Thanks,
Paul
On 8/13/20, 9:48 AM, "serviceability-dev on behalf of Hohensee, Paul"
<serviceability-dev-r...@openjdk.java.net on behalf of hohen...@amazon.com> wrote:
Will do.
On 8/13/20, 7:08 AM, "linzang(臧琳)" <linz...@tencent.com> wrote:
Thanks Paul！
May I ask your help to push it?
BRs,
Lin
> On Aug 13, 2020, at 10:06 PM, Hohensee, Paul <hohen...@amazon.com>
wrote:
>
> +1, except that the indentation for the final 'else' clause needs to
be 4 spaces instead of 3. :)
>
> Thanks,
> Paul
>
> On 8/12/20, 6:21 PM, "serguei.spit...@oracle.com"
<serguei.spit...@oracle.com> wrote:
>
> Hi Lin.
>
> Thank you for the update.
> It looks good.
>
> Thanks,
> Serguei
>
>
>> On 8/12/20 17:08, linzang(臧琳) wrote:
>> Hi Paul and Serguei,
>> Thanks for your comments, here is the updated patch:
http://cr.openjdk.java.net/~lzang/8251374/webrev02/
>>
>> BRs,
>> Lin
>>
>> On 2020/8/13, 12:55 AM, "serguei.spit...@oracle.com"
<serguei.spit...@oracle.com> wrote:
>>
>> Hi Lin,
>>
>> It looks good.
>> Just one comment.
>>
>> + System.err.println("Fail: invalid option: '" +
subopt +"'");
>> + System.exit(1);
>>
>> Exit needs to be replaced wit usage for consistency.
>>
>> Thanks,
>> Serguei
>>
>>
>>> On 8/10/20 19:57, linzang(臧琳) wrote:
>>> Here is the webrev:
http://cr.openjdk.java.net/~lzang/8251374/webrev01/
>>>
>>> BRs,
>>> Lin
>>>
>>>> On 2020/8/11, 10:52 AM, "linzang(臧琳)" <linz...@tencent.com> wrote:
>>>
>>> Hi All,
>>> May I ask your help to review this tiny patch? It fix an
issue that jmap -dump could wrongly accept invalid optioins.
>>> Bugs: https://bugs.openjdk.java.net/browse/JDK-8251374
>>> Patch: (Can not connect to webrev ftp currently, will
try it later, following are all code changes)
>>>
>>> ################################
>>> --- old/src/jdk.jcmd/share/classes/sun/tools/jmap/JMap.java
2020-08-11 10:42:32.044567791 +0800
>>> +++ new/src/jdk.jcmd/share/classes/sun/tools/jmap/JMap.java
2020-08-11 10:42:31.876568681 +0800
>>> @@ -207,6 +207,11 @@
>>> liveopt = "-live";
>>> } else if (subopt.startsWith("file=")) {
>>> filename = parseFileName(subopt);
>>> + } else if (subopt.equals("format=b")) {
>>> + // ignore format (not needed at this time)
>>> + } else {
>>> + System.err.println("Fail: invalid option: '" + subopt
+"'");
>>> + System.exit(1);
>>> }
>>> }
>>> ################################
>>>
>>> Thanks,
>>> Lin
>>>
>>>
>>
>>
>>
>
>
