Hi Dmitry,
In general the fix looks good to me.
Some notes:
please update copyright year;
I'd rename compareIPv6Addr to something like isEqualIPv6Addr or
equalsIPv6Addr;
Also both parameters should be const;
737 // Try to find bind address of preferred address familty first
"familty" -> "family"
--alex
On 08/17/2020 00:21, Dmitry Samersoff wrote:
Hello Everybody,
Please review the fix:
https://cr.openjdk.java.net/~dsamersoff/JDK-8250630/webrev.01/
Binding to IN6ADDR_ANY allow us to serve both IPv4 and IPv6 connections,
but binding to mapped INADDR_ANY (::ffff:0.0.0.0) allow us to serve IPv4
connections only.
So make sure, that IN6ADDR_ANY is preferred over mapped INADDR_ANY if
preferredAddressFamily is not AF_INET
-Dmitry\S
