I've added Claes to the list as he may have an expertise in this area.
83 * <ul>
84 * <li>{@code <null>} - transformed into "//localhost"</li>
85 * <li>localhost - transformed into "//localhost"</li>
86 * <li>hostname - transformed into "//hostname"</li>
87 * <li>hostname:port - transformed into "//hostname:port"</li>
88 * <li>proto:hostname - transformed into "proto://hostname"</li>
89 * <li>proto:hostname:port - transformed into
90 * "proto://hostname:port"</li>
91 * <li>proto://hostname:port</li>
92 * </ul>
Is it worth to add an example to the list above?I wander if this fix needs a CSR.
How did you check this fix does not introduce any regressions?
Thanks,
Serguei
On 8/17/20 08:13, jiefu(傅杰) wrote:
Ping…
Any comments?
Thanks.
Best regards,
Jie
From: serviceability-dev <[email protected]> on behalf of "jiefu(傅杰)" <[email protected]>
Date: Friday, August 7, 2020 at 7:44 AM
To: "[email protected]" <[email protected]>
Subject: Re: RFR: 8251155: HostIdentifier fails to canonicalize hostnames starting with digits(Internet mail)
FYI:
This bug will lead to failures of the following tests on machines with hostname starting from digits.
- test/jdk/sun/tools/jstatd/TestJstatdExternalRegistry.java
- test/jdk/sun/tools/jstatd/TestJstatdPort.java
- test/jdk/sun/tools/jstatd/TestJstatdPortAndServer.java
- test/jdk/sun/tools/jstatd/TestJstatdRmiPort.java
So it's worth fixing it.
Testing:
- tier1-3 on Linux/x64
Thanks.
Best regards,
Jie
From: "jiefu(傅杰)" <[email protected]>
Date: Wednesday, August 5, 2020 at 3:19 PM
To: "[email protected]" <[email protected]>
Subject: RFR: 8251155: HostIdentifier fails to canonicalize hostnames starting with digits
Hi all,
JBS: https://bugs.openjdk.java.net/browse/JDK-8251155
Webrev: http://cr.openjdk.java.net/~jiefu/8251155/webrev.00/
HostIdentifier fails to canonicalize hostname:port if the hostname starts with digits.
The current implementation will get "scheme = hostname".
But the scheme should not be started with digits, which leads to this bug.
Thanks a lot.
Best regards,
Jie
