Migrating this review from the mailing list into a pull request. Some background: when jdb launches debuggee process it passes java options from "options" value for CommandLineLaunch connector and forward options specified before command.
The fix solves several discovered issues: - proper handling of java options with spaces - if both way are used to specify java options, forwarded options override options from "options" value VMConnection class implements tricky logic for "options" field parsing for JFR needs (handling of single and double quotes). I decided to keep it as is to avoid massive test failures with JFR (there is no test coverage for this functionality and I'm not sure I understand all requirements). ------------- Commit messages: - 8234808: jdb quoted option parsing broken Changes: https://git.openjdk.java.net/jdk/pull/211/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=211&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8234808 Stats: 205 lines in 4 files changed: 190 ins; 4 del; 11 mod Patch: https://git.openjdk.java.net/jdk/pull/211.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/211/head:pull/211 PR: https://git.openjdk.java.net/jdk/pull/211
