> Hi,
>
> this is the continuation of the review of the implementation for:
>
> https://bugs.openjdk.java.net/browse/JDK-8227745
> https://bugs.openjdk.java.net/browse/JDK-8233915
>
> It allows for JIT optimizations based on escape analysis even if JVMTI agents
> acquire capabilities to access references
> to objects that are subject to such optimizations, e.g. scalar replacement.
> The implementation reverts such
> optimizations just before access very much as when switching from JIT
> compiled execution to the interpreter, aka
> "deoptimization". Webrev.8 was the last one before before the transition to
> Git/Github:
>
> http://cr.openjdk.java.net/~rrich/webrevs/8227745/webrev.8/
>
> Thanks, Richard.
Richard Reingruber has updated the pull request with a new target base due to a
merge or a rebase. The pull request now
contains 11 commits:
- Merge branch 'master' into JDK-8227745
- Make parameter current_thread of JvmtiEnvBase::check_top_frame() a
JavaThread* again.
With Asynchronous handshakes the type was changed from JavaThread* to Thread*
but this is not necessary as check_top_frame() is not executed during a
handshake
/ safepoint (robehn confirmed).
- Merge branch 'master' into JDK-8227745
- EATests.java: bugfix to prevent ObjectCollectedException
- Better encapsulation of JvmtiDeferredUpdates. Moved
jvmtiDeferredLocalVariableSet to jvmtiDeferredUpdates.hpp
- EscapeBarrier: moved method comments.
- Shuffled parameters of EscapeBarrier constructors to better match each other
- Moved class EscapeBarrier and class JvmtiDeferredUpdates into dedicated
files.
- Merge branch 'master' into JDK-8227745
- Changes based on dholmes' feedback.
EscapeBarrier::sync_and_suspend_all():
- Set suspend flags before handshake because then the setting will be
visible
after leaving the _thread_blocked state in
JavaThread::wait_for_object_deoptimization()
JavaThread::wait_for_object_deoptimization()
- Reuse SpinYield instead of new custom spinning code.
- Do safepoint check after the loop. This is possible because the
set_obj_deopt_flag is done before the handshake.
- Don't set_suspend_equivalent() anymore for more simplicity. It's just an
optimization (that won't pay off here).
Added/updated source code comments.
Additional smaller enhancements.
- ... and 1 more: https://git.openjdk.java.net/jdk/compare/04775f11...af39d5b2
-------------
Changes: https://git.openjdk.java.net/jdk/pull/119/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=119&range=04
Stats: 5788 lines in 52 files changed: 5568 ins; 116 del; 104 mod
Patch: https://git.openjdk.java.net/jdk/pull/119.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/119/head:pull/119
PR: https://git.openjdk.java.net/jdk/pull/119
