On Wed, 21 Oct 2020 17:57:46 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:
>> I'm not sure, I didn't want to add too much `#ifdef` mess. The code will >> compile on other platforms, it just won't be called. Better to add `#ifdef`s >> around all of it? > > Any reason not to have this dcmd supported on all platforms even though the > output is really targeted for use with the perf tool on linux? Would a user > ever have any other use for the output other than with the perf tool on linux? +#ifdef LINUX + DCmdFactory::register_DCmdFactory(new DCmdFactoryImpl<PerfMapDCmd>(full_export, true, false)); +#endif // LINUX If this PR is for Linux only then I wonder if all changes have to be ifdef'ed the same or similar way. ------------- PR: https://git.openjdk.java.net/jdk/pull/760
