On Thu, 22 Oct 2020 08:23:38 GMT, Richard Reingruber <rr...@openjdk.org> wrote:
>> @reinrich did I mess something up when merging this in? > > Depth 1 means top frame and its caller. In > UpdateForPopTopFrameClosure::doit() line 1606(?) the 2 top frames are > deoptimized. Reallocating objects while a frame pop request is processed does > not work if reallocation fails therefore we use an EscapeBarrier to eagerly > reallocate objects beforehand. @fisk for PopFrame the top frame needs to be deoptimized (if compiled) to be able to actually remove it when the thread is resumed. Its caller needs to be deoptimized to be able restart the call. For ForceEarlyReturn it is not necessary to restart. The target can return to a compiled caller and continue executing compiled code. So the caller frame is not deoptimized. @robehn nothing is messed up. Thanks again for doing it. ------------- PR: https://git.openjdk.java.net/jdk/pull/729