On Fri, 30 Oct 2020 14:09:46 GMT, Erik Österlund <eosterl...@openjdk.org> wrote:
>> Oh that's actually horrible. I wonder if it's possible to hoist saving the >> result oop into the InterpreterRuntime entry. And pass the Handle into >> JvmtiExport::post_method_exit(). > > I tried that first, and ended up with a bunch of non-trivial code duplication > instead, as reading the oop is done in both paths but for different reasons. > One to preserve/restore it (interpreter remove_activation entry), but also > inside of JvmtiExport::post_method_exit() so that it can be passed into the > MethodExit. I will give it another shot and see if it is possible to refactor > it in a better way. I uploaded a CR that does pretty much what you suggested, ish. Hope you like it! ------------- PR: https://git.openjdk.java.net/jdk/pull/930
