On Tue, 3 Nov 2020 10:36:21 GMT, Stefan Karlsson <stef...@openjdk.org> wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Code review comments from StefanK.
>
> src/hotspot/share/prims/jvmtiTagMapTable.cpp line 185:
>
>> 183: // Serially remove unused oops from the table, and notify jvmti.
>> 184: void JvmtiTagMapTable::unlink_and_post(JvmtiEnv* env) {
>> 185:
>
> Stray newline
that's a useful newline.
> src/hotspot/share/prims/jvmtiTagMapTable.cpp line 258:
>
>> 256: int rehash_len = moved_entries.length();
>> 257: // Now add back in the entries that were removed.
>> 258: for (int i = 0; i < moved_entries.length(); i++) {
>
> rehash_len is read, but not used in for loop condition.
It's in the logging message below. I'll use it in the loop too.
-------------
PR: https://git.openjdk.java.net/jdk/pull/967
