On Tue, 3 Nov 2020 21:12:49 GMT, Albert Mingkun Yang <ay...@openjdk.org> wrote:
>> Coleen Phillimore has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains five commits:
>>
>> - Merge branch 'master' into jvmti-table
>> - Merge branch 'master' into jvmti-table
>> - More review comments from Stefan and ErikO
>> - Code review comments from StefanK.
>> - 8212879: Make JVMTI TagMap table not hash on oop address
>
> src/hotspot/share/utilities/hashtable.cpp line 164:
>
>> 162: }
>> 163: }
>> 164: return newsize;
>
> It is existing code, but could be made clearer as part of this PR:
> int newsize;
> for (int i=0; i<arraysize; ++i) {
> newsize = primelist[i];
> if (newsize >= requested)
> break;
> }
> return newsize;
> Additionally, this method could be made `const`, right?
>
> PS: not a review, just a comment in passing
Yes, that is a lot simpler and better. I'd copied that code from another file
without changing it that much.
-------------
PR: https://git.openjdk.java.net/jdk/pull/967
