On Mon, 2 Nov 2020 21:20:27 GMT, Serguei Spitsyn <sspit...@openjdk.org> wrote:

>> I'm not sure. There might be other cases, when remove_activation is called 
>> by the exception code. That's why I didn't want to change it to just true in 
>> this path.
>
> The post_method_exit can come from Zero interpreter:
> src/hotspot/share/interpreter/zero/bytecodeInterpreter.cpp:            
>      CALL_VM_NOCHECK(InterpreterRuntime::post_method_exit(THREAD));

It seems like the case of exception_exit is a condition from the call from 
notice_unwind_due_to_exception() and not the calls from 
InterpreterRuntime::post_method_exit() for both callers.  But maybe if the 
exception is set and not caught, this post_method_exit() is called when 
unwinding to the exception handler.  I can't tell, so leave it to be safe.

-------------

PR: https://git.openjdk.java.net/jdk/pull/930

Reply via email to