Hi Coleen,

On 5/11/2020 10:44 am, Coleen Phillimore wrote:
Apply patch suggested by @cl4es in the bug report.  Passes 
linux-x86-open,linux-x64-open,linux-s390x-open,linux-arm32-debug,linux-ppc64le-debug
 builds with this patch, and tier1.

Sorry but I don't understand the problem or the fix. IIUC the compiler is complaining about the size of the destination buffer - yet I don't see from the local context how the compiler knows what the size of that buffer is. And we pass the size of the buffer precisely to ensure we limit the size of what is written if needed.

Where did the magic numbers in

  "%.19s.%.3d %.50s"

come from?

Thanks,
David
-----

thanks,
Coleen

-------------

Commit messages:
  - 8254270: linux 32 bit build doesn't compile libjdwp/log_messages.c

Changes: https://git.openjdk.java.net/jdk/pull/1067/files
  Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=1067&range=00
   Issue: https://bugs.openjdk.java.net/browse/JDK-8254270
   Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
   Patch: https://git.openjdk.java.net/jdk/pull/1067.diff
   Fetch: git fetch https://git.openjdk.java.net/jdk pull/1067/head:pull/1067

PR: https://git.openjdk.java.net/jdk/pull/1067

Reply via email to